-
-
Notifications
You must be signed in to change notification settings - Fork 840
Expose more options in similar videos tool #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the similar videos tool by exposing previously hardcoded scanning parameters to the user interface, allowing customization of video comparison settings that were previously fixed.
Key changes include:
- Added UI controls for skip forward amount, video hash duration, and crop detection method in similar videos tool
- Updated cache file naming to include these parameters, ensuring proper cache isolation
- Improved UI layout and translations for video settings
Reviewed Changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
krokiet/ui/tool_settings.slint | Added new UI controls for video scanning parameters and improved layout spacing |
krokiet/ui/settings.slint | Added property definitions for new video configuration options |
krokiet/src/settings/model.rs | New file containing settings data structures and default values |
krokiet/src/settings/combo_box.rs | New file with combo box utilities including video crop detection options |
czkawka_core/src/tools/similar_videos.rs | Enhanced video similarity tool with configurable parameters and validation |
czkawka_core/src/common_cache.rs | Updated cache file naming to include video scan parameters |
Comments suppressed due to low confidence (2)
krokiet/src/settings/model.rs:21
- [nitpick] The constant name
DEFAULT_MINIMAL_FRAGMENT_DURATION_VALUE
is inconsistent with other naming patterns. Consider renaming toDEFAULT_MINIMAL_FRAGMENT_DURATION
to match the pattern used by other constants likeDEFAULT_SKIP_FORWARD_AMOUNT
.
pub const DEFAULT_MINIMAL_FRAGMENT_DURATION_VALUE: f32 = 5.0;
czkawka_core/src/tools/similar_videos.rs:78
- The function name
crop_detect_from_str_opt
is inconsistent with Rust naming conventions. Consider renaming totry_crop_detect_from_str
to better indicate it returns an Option and follows thetry_*
pattern for fallible operations.
pub fn crop_detect_from_str_opt(s: &str) -> Option<Cropdetect> {
Fixes #1440 (partially - it allows change, previously hardcoded scan paramers - changing them, will change used cache files)