Skip to content

Conversation

qarmin
Copy link
Owner

@qarmin qarmin commented Jul 31, 2025

Fixes #1440 (partially - it allows change, previously hardcoded scan paramers - changing them, will change used cache files)

@qarmin qarmin requested a review from Copilot July 31, 2025 19:31
Copilot

This comment was marked as outdated.

@qarmin qarmin requested a review from Copilot August 1, 2025 19:45
Copilot

This comment was marked as outdated.

@qarmin qarmin requested a review from Copilot August 2, 2025 12:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the similar videos tool by exposing previously hardcoded scanning parameters to the user interface, allowing customization of video comparison settings that were previously fixed.

Key changes include:

  • Added UI controls for skip forward amount, video hash duration, and crop detection method in similar videos tool
  • Updated cache file naming to include these parameters, ensuring proper cache isolation
  • Improved UI layout and translations for video settings

Reviewed Changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
krokiet/ui/tool_settings.slint Added new UI controls for video scanning parameters and improved layout spacing
krokiet/ui/settings.slint Added property definitions for new video configuration options
krokiet/src/settings/model.rs New file containing settings data structures and default values
krokiet/src/settings/combo_box.rs New file with combo box utilities including video crop detection options
czkawka_core/src/tools/similar_videos.rs Enhanced video similarity tool with configurable parameters and validation
czkawka_core/src/common_cache.rs Updated cache file naming to include video scan parameters
Comments suppressed due to low confidence (2)

krokiet/src/settings/model.rs:21

  • [nitpick] The constant name DEFAULT_MINIMAL_FRAGMENT_DURATION_VALUE is inconsistent with other naming patterns. Consider renaming to DEFAULT_MINIMAL_FRAGMENT_DURATION to match the pattern used by other constants like DEFAULT_SKIP_FORWARD_AMOUNT.
pub const DEFAULT_MINIMAL_FRAGMENT_DURATION_VALUE: f32 = 5.0;

czkawka_core/src/tools/similar_videos.rs:78

  • The function name crop_detect_from_str_opt is inconsistent with Rust naming conventions. Consider renaming to try_crop_detect_from_str to better indicate it returns an Option and follows the try_* pattern for fallible operations.
pub fn crop_detect_from_str_opt(s: &str) -> Option<Cropdetect> {

@qarmin qarmin merged commit 401ae4b into master Aug 2, 2025
26 checks passed
@qarmin qarmin deleted the video branch August 2, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too Many False Positives With Ad Files
1 participant