Add format options support pm fix #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llmII
force-pushed
the
add-format-options-support-pm-fx
branch
2 times, most recently
from
96f6b27 to
f8f7e3c
Compare
This commit introduces the ability to private message in such a way as to be considered "stable". Each bot get its own discriminator and this makes it where if you were to connect 2 bots to the same Discord identity but 2 different IRC networks when you send a private message since the discriminator is required it will not accidentally be sent to both IRC networks wherein both networks have a client with the same nick. This also enhances privacy since it isn't guaranteed the same person has the same nick on both networks. Pending: log a fatal and exit if Discriminator == "".
llmII
force-pushed
the
add-format-options-support-pm-fx
branch
from
f8f7e3c to
93d2a70
Compare
Allows for the user to define how messages are formatted back and forth between Discord and IRC.
|
Need to check for Done in c7dc222 |
This change lets us have our cake and eat it too. If the configuration for a format is `" "` then it will just not send that message type. Previously this worked but it would send an empty message which Discord just really doesn't like!
Merge branch 'formatting-options-feature' into add-format-options-support-pm-fx
Allow for an empty format of `" "` to basically drop PMs (no introduction sent either).
llmII
changed the title
|
I'd also like to propose a default PM format of: which would yield something like: llmII@ircnetwork: wrote a PM Which gives the Discord user enough information to know how to PM back and who to PM back but omits information such as what server the Discord relay is connected to and/or hostmasks. That said, I think it would be best to discuss the default formats but commit this as is and handle all formatting options for all merged formatting related things in another PR. |
No, we shouldn't warn. Co-authored-by: Qais Patankar <[email protected]>
When it is first load, if an invalid key is present in `discord_format` we inform the user of a fatal error and exit. If it's on reload we don't apply the new format and inform the user such was not done and that there is an error with an invalid key being present in the `discord_format` setting.
When it is first load, if an invalid key is present in `discord_format` we inform the user of a fatal error and exit. If it's on reload we don't apply the new format and inform the user such was not done and that there is an error with an invalid key being present in the `discord_format` setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #75 and #76.
Integrates support for PM's with the formatting options so that way they can have a way of being formatted as well.
Figure that all single-sourced messages (JOIN/PART/QUIT (NICK via #72 and formatting for NICK via #79)) relayed towards Discord should have a way to format it.
Still pending figuring out best way to document this in
README.md.