Support stderr #33
Merged
Support stderr #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraspaud
reviewed
Apr 25, 2025
pytroll_runner/__init__.py
Outdated
| out, err = process.communicate() | ||
| logger.debug(f"After having run the script: [stdout]{out} [stderr]{err}") | ||
| if err: | ||
| return out + err |
There was a problem hiding this comment.
Would it hurt to remove the "if" and always return out + err?
pytroll_runner/tests/test_runner.py
Outdated
Comment on lines
69
to
71
| @pytest.fixture(params=[False, True]) | ||
| def dumped_to_std_err(request): | ||
| return request.param |
There was a problem hiding this comment.
Really nice with request.param, works well for this use case!
One thing though: I think it might be even better to use eg sys.stdout and sys.stderr as values here. In which case, the fixture should probably change name, eg "output_stream"?
|
also, pre-commit isn’t happy. |
pkhalaj
force-pushed
the
feature/support-std-error
branch
from
f7172b6 to
8c33b86
Compare
Co-authored-by: Martin Raspaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.