Fix premature closing of the subscriber #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adybbroe
reviewed
Dec 4, 2023
| @@ -85,7 +85,7 @@ def read_config(config_file): | |||
| def run_from_new_subscriber(command, subscriber_settings): | |||
| """Run the command with files gotten from a new subscriber.""" | |||
| with closing(create_subscriber_from_dict_config(subscriber_settings)) as sub: | |||
| return run_on_messages(command, sub.recv()) | |||
| yield from run_on_messages(command, sub.recv()) | |||
There was a problem hiding this comment.
How can we test this? Why was this not caught before?
There was a problem hiding this comment.
This wasn't caught before because stopping the subscriber didn't affect the behaviour of the patched subscriber. With the change in posttroll's testing function, the patched subscriber now stops "recieving" when the subscriber is stopped. This will the exhibit the problem. So the tests are actually already sufficient to avoid the problem from coming back, but they need posttrolls main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a premature closing of the subscriber leading to the runner being deaf.
There is no test added here as I am counting on pytroll/posttroll#57 to reveal the problem (it does locally)