Make sure old files are not picked up and add regex to search log output #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage ? 98.73%
=======================================
Files ? 2
Lines ? 316
Branches ? 0
=======================================
Hits ? 312
Misses ? 4
Partials ? 0 |
pnuu
requested changes
Aug 18, 2023
|
@pnuu I think I addressed your comments. |
|
Ok, this supports now regexes also. |
pnuu
approved these changes
Aug 23, 2023
| pub.send(message) | ||
|
|
||
|
|
||
| def generate_message_from_log_output(publisher_config, mda, log_output): | ||
| """Generate message for the filenames present in the log output.""" | ||
| new_files = re.findall(publisher_config["output_files_log_regex"], str(log_output)) |
There was a problem hiding this comment.
So if there's a regex pattern in the config, the output from the called script is parsed to catch the filenames? Handy.
Co-authored-by: Panu Lahtinen <[email protected]>
mraspaud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR saves the state of the directory to make sure only new files are picked.
Also adds the possibility to use a configured regex to parse new filenames from the script log.