Skip to content

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia self-assigned this May 19, 2025
@lanluo-nvidia lanluo-nvidia added WIP Work is in progress, pull request should not be merged yet and removed cla signed labels May 19, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 20, 2025
@github-actions github-actions bot requested a review from narendasan May 20, 2025 01:57
@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review May 21, 2025 11:00
@github-actions github-actions bot requested a review from narendasan May 30, 2025 20:40
@github-actions github-actions bot added component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters component: api [C++] Issues re: C++ API component: evaluators Issues re: Specific op evaluators component: runtime component: partitioning labels Jun 3, 2025
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after minor docs update

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/setup.py	2025-06-03 21:39:20.561802+00:00
+++ /home/runner/work/TensorRT/TensorRT/setup.py	2025-06-03 21:39:49.665685+00:00
@@ -71,10 +71,11 @@
            )
        else:
            __cuda_version__ = versions["__cuda_version__"]
        __tensorrt_version__ = versions["__tensorrt_version__"]

+
load_dep_info()

dir_path = os.path.join(str(get_root_dir()), "py")

IS_AARCH64 = platform.uname().processor == "aarch64"
@@ -154,11 +155,15 @@
IS_SBSA = True if IS_AARCH64 and not IS_JETPACK else False

if IS_JETPACK and "bdist_wheel" in sys.argv:
    needs_append_plat_name = True
    for i, arg in enumerate(sys.argv):
-        if arg == "--plat-name" and i+1 < len(sys.argv) and sys.argv[i+1] == "linux_tegra_aarch64":
+        if (
+            arg == "--plat-name"
+            and i + 1 < len(sys.argv)
+            and sys.argv[i + 1] == "linux_tegra_aarch64"
+        ):
            needs_append_plat_name = False
            break
        if arg == "--plat-name=linux_tegra_aarch64":
            needs_append_plat_name = False
            break

@lanluo-nvidia lanluo-nvidia merged commit 7ea3638 into main Jun 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel: linux-jetpack cla signed component: api [C++] Issues re: C++ API component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: evaluators Issues re: Specific op evaluators component: lowering Issues re: The lowering / preprocessing passes component: partitioning component: runtime component: tests Issues re: Tests documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants