Make deferred-annotation errors optional (depends on version) #2096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
added
the
topic: conformance tests
Member
|
Thanks, this seems fine. Maybe in the long term we should have some way to configure the Python version in the conformance test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forward references in
conformance/tests/annotations_forward_refs.pyare no longer errors on Python 3.14, so it seems reasonable to me to mark them asE?instead ofE, because whether or not this is an error depends on how the type checkers are configured (what Python version are they targeting?).I saw that a similar pattern was used in
typeddicts_alt_syntax.pyto mark version-depend errors withE?, but I'm obviously open to other suggestions (e.g. removing these test assertions alltogether, if possible).