-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
PEP 791: address PEP review comments #4430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
963f154
to
86e15a2
Compare
* add submodule variant
86e15a2
to
8cdce7a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Hugo van Kemenade <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
177f73b
to
ae03c4b
Compare
@vstinner, "Open Issues" section was removed. Please review. @serhiy-storchaka, I would appreciate your feedback as this is close to final version (for SC). Let me know if you feel that argumentation is not strong enough. I think it's better to mark this PEP as "Deferred" than reject the idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vstinner, perhaps this can be merged, regardless on Serhiy feedback? |
Merged, thanks. |
Thanks, I'll go through comments again to see if I miss something (it seems I did). Would it be ok just update thread by a new post or it's better to start a new thread? |
You can just send a new message in the existing thread. |
PEP 123: Summary of changes
)📚 Documentation preview 📚: https://pep-previews--4430.org.readthedocs.build/pep-0791/