gh-20476: Fix AssertionError (too many plugin hook passes) on dataclass attribute redefinition #20521
+56
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-20476
There was a crash in the dataclass plugin when an attribute was re-defined, to wit:
AssertionError: Internal error: too many class plugin hook passesfrom the repro script in the issue. Changed a couple things here:mypy/plugins/dataclasses.pydetect re-defined attrs. If so, the plugin now skips the transformation for that attribute, allowing the reporting of a [no-redef] error instead of triggering a crash.mypy/semanal_main.pyto break out of potential infinite loops caused by class plugin hooks that don't reach a stable state.And added a test! All other tests pass as well.