Skip to content

bpo-31715 Add mimetype for extension .mjs #3908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asvetlov merged 7 commits into from
Oct 8, 2018
Merged

bpo-31715 Add mimetype for extension .mjs #3908

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7c9d069
bpo-31715 Add mimetype for extension .mjs
bmeck Oct 6, 2017
f54e12c
fixup: add news
MylesBorins Aug 15, 2018
58482ed
Merge pull request #1 from MylesBorins/fix-issue-31715
bmeck Aug 15, 2018
f2d7b6c
move text/javascript to application/javascript
bmeck Oct 8, 2018
695d960
Merge branch 'fix-issue-31715' of https://github.com/bmeck/cpython in…
bmeck Oct 8, 2018
e9f1fef
Update 2018-08-15-16-22-30.bpo-31715.Iw8jS8.rst
asvetlov Oct 8, 2018
6c38bfa
Update 2018-08-15-16-22-30.bpo-31715.Iw8jS8.rst
asvetlov Oct 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/mimetypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,7 @@ def _default_mime_types():
'.mht' : 'message/rfc822',
'.mhtml' : 'message/rfc822',
'.mif' : 'application/x-mif',
'.mjs' : 'text/javascript',
Copy link
Contributor

@asvetlov asvetlov Oct 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be application/javascript for consistency with .js

Copy link

@mathiasbynens mathiasbynens Oct 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text/javascript is correct, and .js should be changed to use it as well. Please see the discussion above. #3908 (comment)

Copy link
Member

@ammaraskar ammaraskar Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asveltov's rationale for application/javascript is explained here: https://bugs.python.org/issue34875

Copy link

@mathiasbynens mathiasbynens Oct 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be open to adding .mjs support with application/javascript until https://datatracker.ietf.org/doc/draft-ietf-dispatch-javascript-mjs/ gets officially accepted? It would be better to have some support than to have none at all, given that people are already running into issues with SimpleHTTPServer.

Note that Google Chrome already explicitly supports mjs: https://chromium-review.googlesource.com/c/chromium/src/+/1117070 (with text/javascript)

Copy link

@mathiasbynens mathiasbynens Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reading this, it sounds like you are open to that. That’s great! I look forward to Python supporting mjs, and eventually serving it as text/javascript.

'.mov' : 'video/quicktime',
'.movie' : 'video/x-sgi-movie',
'.mp2' : 'audio/mpeg',
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2018-08-15-16-22-30.bpo-31715.Iw8jS8.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Add mimetype for file extension ``.mjs``. This will allow ``python -m`` to
support applications attempting to load ECMAScript Modules with the ``.mjs``
extension.