Skip to content

bpo-30438 Added test confirming failure to untar from readonly directory #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
catherinedevlin wants to merge 2 commits into from
Closed

bpo-30438 Added test confirming failure to untar from readonly directory #1768

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
067e044
Added test confirming issue 30438: failure to untar from readonly dir…
catherinedevlin May 23, 2017
244726b
Merge branch 'master' into issue_30438
catherinedevlin May 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions Lib/test/test_tarfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2593,6 +2593,30 @@ def test_keyword_only(self, mock_geteuid):
tarfl.extract, filename_1, TEMPDIR, False, True)


# Enable this test when Issue 30438 is fixed
@unittest.skip
class ExtractTarredReadonlyDirectoryTest(unittest.TestCase):

def test_extract_tarred_readonly_directory(self):
"Issue 30438: tarring, then extracting, a read-only directory with a file should succeed"

read_only_dir_name = os.path.join(TEMPDIR, 'read_only_dir')
file_name = os.path.join(read_only_dir_name, 'sample.txt')
tarfile_name = os.path.join(TEMPDIR, 'sample.tar')

os.makedirs(read_only_dir_name)
with open(file_name, 'w') as outfile:
outfile.write('')

os.chmod(read_only_dir_name, 0o555) # Read and Execute permissions
os.chmod(file_name, 0o444) # Read Only permission
with tarfile.open(tarfile_name, "w") as tarfl:
tarfl.add(read_only_dir_name)
tarfl.add(file_name)

tarfile.open(tarfile_name).extractall()


def setUpModule():
support.unlink(TEMPDIR)
os.makedirs(TEMPDIR)
Expand Down