gh-143672: convert the struct module to AC #143673
Open
+425
−192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Jan 11, 2026
| See help(struct) for more on format strings. | ||
| Return a new Struct object which writes and reads binary data according | ||
| to the format string. See help(struct) for more on format strings. |
Member
There was a problem hiding this comment.
what is the reason for newline -> double space change? I was not aware that this is required.
Contributor
Author
There was a problem hiding this comment.
In some docstrings "See help(struct) for more on format strings." was separated to a new paragraph. In some - no. Looks as a waste of space, especially in help(struct) output.
| / | ||
| *args: array | ||
| Pack args to the writtable buffer according to the format self. |
Member
There was a problem hiding this comment.
Suggested change
| Pack args to the writtable buffer according to the format self. | |
| Pack args to the writtable buffer according to the struct's format string. |
Contributor
Author
There was a problem hiding this comment.
Too long. Beware @permit_long_summary.
| strings."); | ||
| *args: array | ||
| Return a bytes object with args, packed according the format self. |
Member
There was a problem hiding this comment.
Suggested change
| Return a bytes object with args, packed according the format self. | |
| Return a bytes object with args, packed according the struct's format string. |
Contributor
Author
|
BTW, I'm not attached to docstrings. IMO, they aren't good and I tried to improve that. But I can just revert that stuff and keep old doctsrings almost literally (summary line is required, though). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.