gh-142555: Fix null pointer dereference in array.__setitem__ via re-entrant __index__ #142713
+107
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
reviewed
Dec 14, 2025
hugovk
reviewed
Dec 15, 2025
Misc/NEWS.d/next/Core_and_Builtins/2025-12-15-02-02-45.gh-issue-142555.EC9QN_.rst
Outdated
Show resolved
Hide resolved
…e-142555.EC9QN_.rst Co-authored-by: Hugo van Kemenade <[email protected]>
picnixz
previously requested changes
Dec 27, 2025
Misc/NEWS.d/next/Library/2025-12-15-02-02-45.gh-issue-142555.EC9QN_.rst
Outdated
Show resolved
Hide resolved
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…C9QN_.rst Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
reviewed
Dec 27, 2025
picnixz
added
needs backport to 3.13
picnixz
reviewed
Dec 27, 2025
picnixz
reviewed
Dec 27, 2025
picnixz
reviewed
Dec 27, 2025
Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
approved these changes
Dec 27, 2025
picnixz
reviewed
Jan 1, 2026
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
I think we can merge this is as is, or did you have something else in mind @serhiy-storchaka?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
array:*_setitemfunctions & co may crash on re-entrant__index__#142555