gh-141497: make ipaddress.IP{v4,v6}Network.hosts() return an iterator

[XChaitanyaX]

• Issue: Incomplete return type for ipaddress.IPv4Network.hosts() #141497

[dr-carlos]

A short test should be added in the relevant part(s) of test_ipaddress.py to ensure that the hosts() method always returns an iterator.

[dr-carlos]

The tests looks good, but this should still pass on main. Could you add similar tests for the specific cases affected by this PR?

cpython/Lib/test/test_ipaddress.py

Lines 1507 to 1510 in 17a1a05

	# special case where the network is a /32
	addrs = [ipaddress.IPv4Address('1.2.3.4')]
	str_args = '1.2.3.4/32'
	tpl_args = ('1.2.3.4', 32)

cpython/Lib/test/test_ipaddress.py

Lines 1525 to 1527 in 17a1a05

	addrs = [ipaddress.IPv6Address('2001:658:22a:cafe::1'), ]
	str_args = '2001:658:22a:cafe::1/128'
	tpl_args = ('2001:658:22a:cafe::1', 128)

[XChaitanyaX]

but this should still pass on main

the workflow shows an error in test import, I think it is a known issue I saw it somewhere....

[sharktide]

LGTM

[sharktide]

Although we probably should re-run the failed test. It seems unrelated.

[XChaitanyaX]

Is there a way to rerun the workflow?? I don't see any in checks

[sharktide]

Is there a way to rerun the workflow?? I don't see any in checks

You can't, a core developer or official triager has to. I am not officially either. It is fine for now. They probably will when they see this PR of you haven't pushed any commits in the meantime because losing commits re-runs all tests.

[sharktide]

Core review? @serhiy-storchaka

[bedevere-app]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[picnixz]

Sorry my previous was incomplete but I was on mobile.

Changes were addressed.