Refactor bootstrap() Method in src/fromager/bootstrapper.py #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LalatenduMohanty
force-pushed
the
refactor_bootstrapper
branch
from
111dbb4 to
60beb14
Compare
tiran
requested changes
Dec 1, 2025
LalatenduMohanty
force-pushed
the
refactor_bootstrapper
branch
from
60beb14 to
68217d8
Compare
Refactoring bootstrap() Method in src/fromager/bootstrapper.py. Currently it has 10+ Responsibilities (230 lines). Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty
force-pushed
the
refactor_bootstrapper
branch
from
68217d8 to
677646b
Compare
Member
Author
|
@tiran The fixes for the review comments are in a different commit, once the chnages looks good I plan to squash the commits to a single commit. |
tiran
requested changes
Dec 2, 2025
Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty
force-pushed
the
refactor_bootstrapper
branch
from
677646b to
eea555c
Compare
Member
|
This looks OK to me, but I see @tiran also had review comments so I will leave it for him to approve. |
tiran
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring bootstrap() Method in src/fromager/bootstrapper.py. Currently it has 10+ Responsibilities (230 lines).
This will help me implement #713 with minimal changes. Currently I have kept each step of refactor in different commits for easy review.
Fixes #873