fix: include package name in exception messages

[andre-motta]

Add package name context to exception formatting to identify which
package failed during build errors. The package name is added by
FromagerLogRecord when messages are logged, and _format_exception
handles formatting chained exceptions with 'because' syntax.

Improve parallel build error handling to preserve package context
across thread boundaries using RuntimeError wrapper.

Tests added to test_external_commands.py verify error logging and
exception formatting include package names and handle chained exceptions.

Update e2e test pattern to match new log format that includes package names.

Closes: #845

[LalatenduMohanty]

@andre-motta src/fromager/commands/download_sequence.py do not use RuntimeError() wrapper. Lets fix that as well

[LalatenduMohanty]

@andre-motta Also 3 e2e tests are failing. PTAL

[LalatenduMohanty]

Here is the fix to the e2e failures

diff --git a/src/fromager/__main__.py b/src/fromager/__main__.py
index 4c6428c..168de15 100644
--- a/src/fromager/__main__.py
+++ b/src/fromager/__main__.py
@@ -287,7 +287,7 @@ def invoke_main() -> None:
             err,
             exc_info=True,
         )  # log the full traceback details to the debug log file, if any
-        logger.error(f"ERROR: {_format_exception(err)}")
+        logger.error(_format_exception(err))
         if _DEBUG:
             raise
         sys.exit(1)

[andre-motta]

Addressed all feedback

[dhellmann]

It looks like the test job failures are due to the changes in the message format. That should be easy enough to fix. The change itself looks good.

[andre-motta]

It looks like the test job failures are due to the changes in the message format. That should be easy enough to fix. The change itself looks good.

Fixed the format, I also made some other changes as the fix I did to the raises actually mean I don't need the suggested changes in def _format_exception(exc) as they were causing duplication of the package name in the logs now that the exception context is correctly bubbled up to the logger class.

Heres an example of the duplication:

ERROR stevedore: stevedore: Unable to resolve requirement specifier stevedore==5.2.0 with constraint stevedore==4.0.0 because stevedore: found no match...

[LalatenduMohanty]

@andre-motta I am wondering if the current proposed fix is relatively fragile. Also I am also re-thinking about use of RuntimeError or should we take a different approach.

[tiran]

A while ago I had the idea to wrap our hooks to have more detailed exceptions as well as separate exception classes for resolver, sdist, wheel build, and so on. Please take a look at the rough prototype https://github.com/tiran/fromager/pull/new/hook-exceptiongroup .

[rd4398]

The changes look okay but looks like a rebase is needed.

[dhellmann]

I think we could land this if it was rebased. Some of the other suggested improvements could come later.

[andre-motta]

Rebased on main.

[LalatenduMohanty]

I created issue to track the improvement suggestion by @tiran in #876

[LalatenduMohanty]

@andre-motta There are two commits now, do we need two commits?

[andre-motta]

Fixing it now @LalatenduMohanty