test(graph): fix constraint tests for Requirement objects #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update test_graph.py to use Requirement objects instead of strings for constraint parameters, following the API change in commit 718d2f3. Changes: - Pass Requirement objects to add_dependency() constraint parameter - Update assertions to check Requirement type instead of string - Change empty constraint checks from "" to None - Account for canonical ordering in constraint string representation (e.g., ">=1.0,<3.0" becomes "<3.0,>=1.0") Fixes: 718d2f3 Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty
force-pushed
the
fix_types_in_test_graph
branch
from
d9b94a1 to
7d8dbf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(graph): update constraint tests for Requirement type
Update test_graph.py to use Requirement objects instead of strings
for constraint parameters, following the API change in commit 718d2f3.
Changes:
(e.g., ">=1.0,<3.0" becomes "<3.0,>=1.0")
All tests pass with mypy type checking enabled.
Fixes compatibility with: 718d2f3 (chore: use Requirement | None for constraint)