chore(graph): use Requirement | None for constraint #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhellmann
reviewed
Oct 27, 2025
src/fromager/dependency_graph.py
Outdated
| "edges": [edge.to_dict() for edge in self.children], | ||
| } | ||
| if self.constraint: | ||
| dct["constraint"] = str(self.constraint) |
Member
There was a problem hiding this comment.
I would rather we always include the field so that the output format is consistent.
Collaborator
Author
There was a problem hiding this comment.
Okay, I changed the JSON to be either a string or nil for no requirement.
Change the argument type of the new constraints paramemter from `str` to `Requirement | None`. The constraint field in the JSON is now either a string or `nil`. See: python-wheel-build#813 Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
graph-constraint-type
branch
from
e67f8de to
718d2f3
Compare
dhellmann
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the argument type of the new constraints paramemter from
strtoRequirement | None. The constraint key is not written to the graph JSON if the field is None.See: #813