feat(graph): add --reduce option to to-dot command #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new --reduce flag to the graph to-dot command that filters the dependency graph to only include nodes with fromager customizations (overrides, settings, patches, plugins, or pre-built wheels). The reduced graph preserves dependency relationships by creating direct edges between customized nodes, skipping intermediate nodes without customizations. Original requirement specifications are tracked and displayed in edge labels for better clarity. Key changes: - Add --reduce command line option to to-dot command - Implement has_customizations() to identify nodes with customizations - Implement reduce_graph() to build filtered dependency relationships - Track original requirement strings for proper edge labeling - Use req_type.is_build_requirement property for build dependency checks This feature helps visualize which packages in a dependency tree actually have fromager customizations while maintaining essential dependency relationships. Cursor chat transcript: https://gist.github.com/dhellmann/e362954e00a7270dcc71037382f53853 Co-authored-by: Claude 3.5 Sonnet (Anthropic AI Assistant) Signed-off-by: Doug Hellmann <[email protected]>
Member
Author
|
Here are a few sample output files showing the difference between a full graph and a reduced graph: docling-graph.json.dot.pdf |
tiran
reviewed
Sep 7, 2025
Member
|
@dhellmann can you pass a graph file which has packages with customization, so that it would be easier for me to test the PR? |
dhellmann
force-pushed
the
reduce-graph
branch
from
6143e21 to
b9d5f47
Compare
Rename the --reduce command line option to --overrides-only to better reflect its purpose of filtering the dependency graph to show only nodes with fromager overrides. Update the help text to clarify that it includes nodes with settings, patches, or plugins, removing the redundant mention of "customizations" and "overrides" in the same description. Co-authored-by: Claude 3.5 Sonnet (Anthropic AI Assistant) Signed-off-by: Doug Hellmann <[email protected]>
dhellmann
force-pushed
the
reduce-graph
branch
from
b9d5f47 to
1fb5f94
Compare
Member
Author
The graph file itself doesn't record which packages had customizations, though we could add that. I'll upload the graph files I used to produce the PDFs but you'll have to run fromager with the context from our downstream configuration repo to get the same output. |
LalatenduMohanty
approved these changes
Sep 8, 2025
LalatenduMohanty
requested changes
Sep 23, 2025
tiran
reviewed
Sep 24, 2025
Simplify the logic for reducing a graph by moving the check into the PackageBuildInfo class.
dhellmann
force-pushed
the
reduce-graph
branch
from
9fc7a55 to
7eb87e9
Compare
rd4398
reviewed
Oct 2, 2025
Contributor
rd4398
left a comment
rd4398
left a comment
There was a problem hiding this comment.
This looks good! I see there are few comments on MR so I will wait for them to be resolved before I hit approve
LalatenduMohanty
approved these changes
Oct 27, 2025
LalatenduMohanty
merged commit e0681a3
into
python-wheel-build:main
111 of 112 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new --reduce flag to the graph to-dot command that filters the
dependency graph to only include nodes with fromager customizations
(overrides, settings, patches, plugins, or pre-built wheels).
The reduced graph preserves dependency relationships by creating direct
edges between customized nodes, skipping intermediate nodes without
customizations. Original requirement specifications are tracked and
displayed in edge labels for better clarity.
Key changes:
This feature helps visualize which packages in a dependency tree actually
have fromager customizations while maintaining essential dependency
relationships.
Fixes #715
Cursor chat transcript: https://gist.github.com/dhellmann/e362954e00a7270dcc71037382f53853