Skip to content

Conversation

@tiran
Copy link
Collaborator

@tiran tiran commented Aug 26, 2024

Add APIs to analyze a directory tree or an archive (zip, tar). By default, all regular files with executable bit are analyzed except for files that have a .py, .sh, or docs extension (md, rst, txt). In addition, files with a pattern like lib*.so, lib*.so.1.2.3, and ld-*.so are analyzed, too.

@tiran tiran requested review from dhellmann and shubhbapna August 26, 2024 12:18
@tiran tiran marked this pull request as ready for review August 26, 2024 12:21
@tiran
Copy link
Collaborator Author

tiran commented Aug 26, 2024

Depends on PR #5

@tiran tiran force-pushed the analyze_tree branch 2 times, most recently from 951e560 to 4ff8468 Compare August 26, 2024 13:52
Comment on lines 124 to 127
if is_so_candidate(filename):
# check files that look like a shared library or Python extension
return True
return False

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if is_so_candidate(filename):
# check files that look like a shared library or Python extension
return True
return False
return is_so_candidate(filename)

Add APIs to analyze a directory tree or an archive (zip, tar). By
default, all regular files with executable bit are analyzed except for
files that have a `.py`, `.sh`, or docs extension (md, rst, txt). In
addition, files with a pattern like `lib*.so`, `lib*.so.1.2.3`, and
`ld-*.so` are analyzed, too.

Signed-off-by: Christian Heimes <[email protected]>
@tiran tiran merged commit b79dbab into python-wheel-build:main Aug 27, 2024
@tiran tiran deleted the analyze_tree branch August 27, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants