Support raw yaml block in tracker #167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
3 tasks
…appy into supprt-raw-yaml-block
for more information, see https://pre-commit.ci
…appy into supprt-raw-yaml-block
for more information, see https://pre-commit.ci
…appy into supprt-raw-yaml-block
for more information, see https://pre-commit.ci
mblayman
requested changes
Dec 6, 2025
Member
mblayman
left a comment
mblayman
left a comment
There was a problem hiding this comment.
This is looking pretty good. Thanks! I have a couple of minor comments before I'm ready to merge.
src/tap/line.py
Outdated
| indented_yaml_block = "\n".join( | ||
| f"{indent}{line}" for line in self._yaml_block.splitlines() | ||
| ) | ||
| yaml_block = f"\n{indent}---\n{indented_yaml_block}\n{indent}..." |
Member
There was a problem hiding this comment.
Just checking... should there be a trailing newline here? I suspect the answer is no because is probably printed later, but I would hate to mistakenly combine test line like <end of yaml>...not ok 43 yada yada
Suggested change
| yaml_block = f"\n{indent}---\n{indented_yaml_block}\n{indent}..." | |
| yaml_block = f"\n{indent}---\n{indented_yaml_block}\n{indent}...\n" |
Contributor
Author
There was a problem hiding this comment.
No newline needed here. in Tracker.generate_tap_report it calls print for each Line object. a Result is still a "Line" (even though it's actually multi-line).
def generate_tap_report(self, test_case, tap_lines, out_file):
self._write_test_case_header(test_case, out_file)
for tap_line in tap_lines:
print(tap_line, file=out_file)
Plus for reassurance, you can see that even if there was no yaml block added, diagnostics in this method did not have a trailing newline either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve support for YAML blocks: