Skip to content

Period(s) in repository "name" causes issues #1328

@Caligatio

Description

@Caligatio
  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • OS version and name: Win10
  • Poetry version: 1.0.0b1
  • Link of a Gist with the contents of your pyproject.toml file: N/A

Issue

Adding a custom [[tool.poetry.source]] whose name includes a period causes issues when paired with http_basic settings. The add_property method on the ConfigSource object blindly splits on periods, including those in the repo name. The side effect of this is that the resulting TOML becomes very "deep."

I'm happy to do a PR but I'm curious to know how much name checking is appropriate.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions