fix invalid variable usages from wrapper outputs #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryyorke
requested changes
Aug 10, 2019
Collaborator
roryyorke
left a comment
roryyorke
left a comment
There was a problem hiding this comment.
Thanks for this clean-up. I guess many of those paths (waring and the missing _np) are not exercised in the tests, or by our users.
Collaborator
Author
|
Sorry, with the added unit tests and some fixes in the periphery concerning the tests directory this turned out to be a bigger PR than initially thought. Should I go ahead and include the cleanup of the other test scripts, too or split this into a different PR? |
bnavigator
commented
Aug 10, 2019
bnavigator
force-pushed
the
fix-unused-vars
branch
from
37dd0e9 to
81d7031
Compare
bnavigator
force-pushed
the
fix-unused-vars
branch
from
81d7031 to
8bc7a4e
Compare
roryyorke
reviewed
Aug 11, 2019
Collaborator
roryyorke
left a comment
roryyorke
left a comment
There was a problem hiding this comment.
This is great, thanks for adding those tests.
I'd like to give @repagh a chance to comment on the API change.
As far as I'm concerned we can merge this, but I doubt I'll be able to get back to Slycot until next weekend at the earliest.
roryyorke
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions tried to use variables which were never defined.