Skip to content

Conversation

@roryyorke
Copy link
Collaborator

This silences deprecation warnings when running tests with newer (1.15?) Numpy. I've only tested it on my own machine (Ubuntu 18.04) with Python 3.6; I'll recheck with other versions when #38 is merged.

This PR also serves as a proof-of-concept of the sort of changes we'd need to make for python-control/python-control#233 (see commit message below for details). Luckily we don't seem to use the .H or .I attributes anywhere. I'm not so sure about .A, which is more difficult to grep for since SS objects have a .A attribute.

commit message:
This involves

  1. changing np.matrix to np.array, or removing conversion from array
    to matrix, and in one case by-hand converting "string
    constructor".
  2. replacing np.matrix "*" with np.array ".dot"; since we're still
    supporting Python 2.7, can't use "@".

This involves

  1. changing np.matrix to np.array, or removing conversion from array
     to matrix, and in one case by-hand converting "string
     constructor".
  2. replacing np.matrix "*" with np.array ".dot"; since we're still
     supporting Python 2.7, can't use "@".
@roryyorke roryyorke merged commit 61537b4 into python-control:master Jan 18, 2019
@roryyorke roryyorke deleted the rory/no-np-matrix branch January 18, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant