-
Notifications
You must be signed in to change notification settings - Fork 458
Fix of list index out of range error in PoFileParser.add_message when translations is empty #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c6bdd65
Fix of index out of bounds error in add_message when translations is …
gabe-sherman 7ede067
small change of error message
gabe-sherman 700eccd
Update translations check in babel/messages/pofile.py
gabe-sherman d1aa71d
added a more descriptive error message
gabe-sherman 9d1d5b3
updated error message and added test in test_pofile.py
gabe-sherman e50d106
Merge branch 'PoFileParser_Patch' of https://github.com/gabe-sherman/…
gabe-sherman 9535041
improved test input to ensure error message is accurate for the corre…
gabe-sherman 2eec963
Update babel/messages/pofile.py
gabe-sherman 3b08f79
Update tests/messages/test_pofile.py
gabe-sherman 71dfd0e
additional test cases added for issue 1134
gabe-sherman a6c9b58
cleanup of whitespace
gabe-sherman 5936e59
Update tests/messages/test_pofile.py
gabe-sherman bff400a
Update tests/messages/test_pofile.py
gabe-sherman aa917b8
additional testing updates
gabe-sherman 64b8437
Merge branch 'PoFileParser_Patch' of https://github.com/gabe-sherman/…
gabe-sherman 546503b
adding new line to test_pofile.py
gabe-sherman f5b7721
Don't add empty translation if we'd raise
akx 2d72d66
Simplify and fix test
akx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.