-
Notifications
You must be signed in to change notification settings - Fork 62
Distribute first points in a BalancingLearner #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fix seems to be only partial: consider for example the case when one learner is much cheaper than all the others. Then as soon as one point arrives, the balancing learner will request all points from another random learner in the queue. If I understand correctly, an empty learner has both an infinite loss and an infinite loss improvement, however some non-empty learners also have the same loss and loss improvement. In that case the problem would arise as well. Therefore it seems to suggest that a better fix would be to sort on |
6e172ef
to
eaa1911
Compare
My problem right now is that the logic is rather nontrivial, and it's hard to follow especially due to very similar variable names. Comments might also help. |
9435ddc
to
7af0f0b
Compare
8025f97
to
49e73f7
Compare
I found another issue that I fixed. I've simplified it now and I think the code is understandable, do you agree? |
b0e8d22
to
d9ceaf7
Compare
b0f5dd4
to
70712e4
Compare
70712e4
to
b2d13a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This fixes #159.
@akhmerov could you take a look at this?