Synchronize fixtures on demand #1147
Merged
+79
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying the FixtureDef
…an the FixtureDef.
…nal fixture function to the wrapper.
… than the FixtureDef.
…iginal fixture function to the wrapper.
…cally. Previously, async coroutines and async generators used as fixture functions were wrapped with a fixture synchronizer during collection time. This allowed fixture function to be run as synchronous functions. This patch changes the synchronization to occur during the pytest_fixture_setup hook. The synchronization is now temporary, which means the wrapper fixture function is restored after the fixture setup has finished.
…xture from a fixture wrapper's arguments.
…t event loop instance.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
- Coverage 89.93% 89.40% -0.54%
==========================================
Files 2 2
Lines 447 434 -13
Branches 53 51 -2
==========================================
- Hits 402 388 -14
- Misses 30 31 +1
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring patch which replaces the preprocessing of fixtures at collection time with on-demand fixture wrapping. The new approach more closely resembles the order in which pytest evaluates non-async fixtures and reduces the number of pytest implementation details used in the code.
Supersedes #669
Closes #668