Skip to content

Conversation

marcsanmi
Copy link
Collaborator

@marcsanmi marcsanmi commented Mar 21, 2025

Important

Remove deprecated armv7 support from profilecli.rb.tpl and pyroscope.rb.tpl.

  • Removal of armv7 support:
    • Removed armv7 section from profilecli.rb.tpl and pyroscope.rb.tpl as it's deprecated.
    • Affects Linux installations for non-64-bit ARM CPUs.

This description was created by Ellipsis for a6552d9. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a6552d9 in 1 minute and 1 seconds

More details
  • Looked at 40 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. Formula/profilecli.rb.tpl:45
  • Draft comment:
    Ensure removal of deprecated armv7 support is intentional.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is asking the PR author to confirm their intention regarding the removal of deprecated armv7 support. This falls under the rule of not asking the author to confirm their intention, which is not allowed.
2. Formula/pyroscope.rb.tpl:53
  • Draft comment:
    Verified removal of deprecated armv7 section is appropriate.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is purely informative and does not provide any actionable feedback or suggestions. It simply states that the removal of a section is appropriate, which is not necessary for the PR author to know.
3. Formula/profilecli.rb.tpl:45
  • Draft comment:
    ARMv7 support removal looks correct as it's deprecated.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
4. Formula/pyroscope.rb.tpl:53
  • Draft comment:
    ARMv7 support removal is appropriate given its deprecation.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None

Workflow ID: wflow_pqdKxN8AmpJZv89z


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@marcsanmi marcsanmi requested a review from simonswine March 21, 2025 15:30
@marcsanmi marcsanmi merged commit fc4c8c4 into main Mar 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants