Add loadBalancerSourceRanges #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Thank you for the contribution @alexz75! I'm terribly sorry for such a long delay in response – for some reason I simply missed the notification.
The PR looks good! There are a couple of notes from me:
- A nit: it would be nice to describe the new option in README - please see my suggestion
- Some CI checks fail: please take a look at our contribution guide:
- Versions need a bump – alas, you need to update versions manually in your branch
- We use helm-docs to generate the documentation
Co-authored-by: Anton Kolesnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added loadBalancerSourceRanges into service to provide network level security