Improve use of url2pathname()
#13515
Draft
+9
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call `_clean_file_url_path()` (thence `url2pathname()`) with a complete URL path, rather than parts of the path after splitting on `/@|%2f/`. This lays the groundwork for using pip's own URL utilities from `link.py`.
barneygale
force-pushed
the
clean-file-url-path-fix
branch
from
1bdb239 to
f7cfbc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
_clean_file_url_path()(thenceurl2pathname()) with a complete URL path, rather than parts of the path after splitting on/@|%2f/.This lays the groundwork for using pip's own URL utilities from
link.py.