-
Notifications
You must be signed in to change notification settings - Fork 290
docs: cleanup #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: cleanup #567
Conversation
e9996c9 to
164d8d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1 +1 @@ | |||
| -e .[dev] | |||
| -e .[dev,docs] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a little odd - shouldn't requirements-dev match [dev]? and [dev] include the requirements for building docs? Could the [dev] extra depend on other extras?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extras can't depend on other extras (my biggest pet peeve - and one that Poetry seems to not have solved when they built a more complicated requirements system), so they'd have to be listed twice. However, this means there might something missing from docs. I thought it was a little nicer to split "docs" from "dev", as often developers are not rebuilding the docs, so it gives more freedom there (since it's easy to ask for multiple extras. You can't as easily make multiple requirements files (it's ugly), and for historical purposes, the requirements-dev should stay the same. But I can also list them twice if better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: you can move extras back to setup.py, then you can make them depend on either other via code, I do this for extras sometimes: https://github.com/scikit-hep/boost-histogram/blob/918caebdf922097fde92df5a5de5442d86aa04c7/setup.py#L51-L64
I often have an "all" if I do this this way.
|
That is really weird, I don't see what would cause such a change in the styling... Wait, I wonder if it's super fences? It's now able to "nest" syntax, so... Still don't see how that would change un-fenced regular styling, like the table. |
|
it might be the mkdocs update, maybe they changed the theme? |
|
Maybe it could be the newer versions? If we have customizations depending on the version of these dependencies, perhaps? Later I'll try to bisect it and see which change causes the failure. |
164d8d4 to
0f520a4
Compare
|
My real goal was to try to set up a way to add tabs (which I didn't manage yet / here, this was just some cleanup while playing with ideas). I think having tabs could really help in a few places:
The tab support for mkdocs seems to be for other themes, so we'd probably have to roll our own. |
I guess so, if it's good practice, even though that would show off less the possibilities of |
|
I would use: This would still show off the abilities of toml, but it would not have to be updated on every Python release, and it includes things like PyPy too! |
|
That would be perfect, indeed, I'd say :-) |
Use oldest-supported-numpy from SciPy in example
0f520a4 to
2a6cc8d
Compare
|
Okay, pushed just the cleanups; the version updates can go in later, not mixed into this PR, since they are affecting the style and will need more work. Superfences too, maybe. I'd like to work on adding tabs to the above mentioned places as well eventually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one note on pytest dev requirement below, then I'm happy
|
If you'd rather, I could rename all -> dev, so that requirements-dev.txt would match |
|
We can tweak or iterate later, it's approved and I fixed the issue mentioned (though, technically, pytest is still there, it just is mismatched (one has a >4, one doesn't), so I plan to merge soonish. I've now started alphabetically sorting the includes, just like in requirements.txt, so that these don't get added multiple times or in different places. |






Adding three things (one commit each):
[docs]and[test]extras, allowing these to be installed individually. Dev no longer includes the docs requirements (but the requirements-dev file does both for you, just like before). Simplifies RtD build a little bit. Bumped the pinned versions of docs requirements. Edit:[test]not[tests], more common (checked Pandas).Support nested markdown in other constructs. @joerick I think there might be one other place where this was needed?Removed for now, might be ruining styling