Skip to content

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Jan 15, 2021

Addressing #529 (no universal yet, but that can be added when #484 is in). Just a SKIP, since that seemed to be the consensus? Without the ! syntax in BUILD I guess only SKIP makes sense (though it is very easy to add).

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice and simple. Just the docs to go, I think :)

@henryiii
Copy link
Contributor Author

Docs are ready for review too. ;)

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henryiii , this looks good!

Just one thing before merge, could you update the options table in the README with this new option?

(A tip - if you open the JS console on the options page e.g. https://cibuildwheel--537.org.readthedocs.build/en/537/options/ , generated README markdown can be copied from there! Kinda weird I know but that was how it was created the first time :) )

@YannickJadoul
Copy link
Member

https://cibuildwheel--537.org.readthedocs.build/en/537/options/

Huh? There's a dedicated docs page of each PR? I never knew about this! Did you perform any dark magic to get this? :-O

@henryiii
Copy link
Contributor Author

Click on the "readthedocs" "check" and it opens the docs for the PR itself, wow. :)

@henryiii henryiii merged commit fba65a6 into pypa:master Jan 21, 2021
@henryiii henryiii deleted the feat/test-skip branch January 21, 2021 02:22
@YannickJadoul
Copy link
Member

Oh, right. Seems I need to read up on this: https://docs.readthedocs.io/en/stable/guides/autobuild-docs-for-pull-requests.html :-)

@YannickJadoul
Copy link
Member

YannickJadoul commented Jan 22, 2021

Of course. I should not read my emails/notifications in random order ;-) #550 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants