-
Notifications
You must be signed in to change notification settings - Fork 288
feat: CIBW_TEST_SKIP #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CIBW_TEST_SKIP #537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice and simple. Just the docs to go, I think :)
Docs are ready for review too. ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @henryiii , this looks good!
Just one thing before merge, could you update the options table in the README with this new option?
(A tip - if you open the JS console on the options page e.g. https://cibuildwheel--537.org.readthedocs.build/en/537/options/ , generated README markdown can be copied from there! Kinda weird I know but that was how it was created the first time :) )
Huh? There's a dedicated docs page of each PR? I never knew about this! Did you perform any dark magic to get this? :-O |
Co-authored-by: Joe Rickerby <[email protected]>
Click on the "readthedocs" "check" and it opens the docs for the PR itself, wow. :) |
Oh, right. Seems I need to read up on this: https://docs.readthedocs.io/en/stable/guides/autobuild-docs-for-pull-requests.html :-) |
Of course. I should not read my emails/notifications in random order ;-) #550 (comment) |
Addressing #529 (no universal yet, but that can be added when #484 is in). Just a SKIP, since that seemed to be the consensus? Without the
!
syntax in BUILD I guess only SKIP makes sense (though it is very easy to add).