Ensure modern version of Python in CIBW_BEFORE_ALL on manylinux #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannickJadoul
force-pushed
the
manylinux-python-version
branch
2 times, most recently
from
457c512 to
15c840b
Compare
YannickJadoul
force-pushed
the
manylinux-python-version
branch
from
15c840b to
c67de74
Compare
Took a while, but seems I am :-) This can be merged, I believe, unless there's a better way to test this? |
henryiii
approved these changes
Nov 24, 2020
|
Good catch @YannickJadoul ! |
Not so much a catch, as well as being bitten by it ;-) But luckily I noticed reasonably quickly why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this line is missing
bin/: https://github.com/joerick/cibuildwheel/blob/2f4ed1fafc6661b1bcfef10c28b47d593e53dfa5/cibuildwheel/linux.py#L125First a commit to make sure I'm correct, though.