Skip to content

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Oct 29, 2020

As proposed by @jcrist, use certifi certificates when downloading files from host using the download function in cibuildwheel/util.py.
This behavior can be overridden using the SSL_CERT_FILE environment variable.

fix #452

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this, @mayeut. I'm +1 on this from a pragmatic standpoint. And considering requests does this, it doesn't seem like much of a risk either.

@mayeut mayeut merged commit 336c80b into pypa:master Oct 31, 2020
@mayeut
Copy link
Member Author

mayeut commented Oct 31, 2020

Thanks for the review @joerick
Merging the approved PR then.

@mayeut mayeut deleted the host-certifi branch October 31, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed

2 participants