feat: support test-groups #2063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
hernyiii/feat/test-groups
branch
3 times, most recently
from
ce9b4d0 to
524cd1c
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
hernyiii/feat/test-groups
branch
from
524cd1c to
febff41
Compare
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
mayeut
requested changes
Nov 2, 2024
Member
mayeut
left a comment
mayeut
left a comment
There was a problem hiding this comment.
Looks good but there are still some places using , instead of as a separator.
Co-authored-by: Matthieu Darbois <[email protected]>
mayeut
reviewed
Nov 2, 2024
mayeut
previously approved these changes
Nov 3, 2024
Signed-off-by: Henry Schreiner <[email protected]>
mayeut
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting test-groups. Fix #2057.