Skip to content

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented May 10, 2024

When building a project that has a pyproject.toml, constraints are not respected when building with the pip frontend.

This commit fixes this by using the same tricks as for the build frontend.

When building a project that has a `pyproject.toml`, constraints
are not respected when building with the `pip` frontend.

This commit fixes this by using the same tricks as for the `build` frontend.
Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like constraints affecting isolated builds (how does one excite which of the half a dozen or so build backends are constrained?), but we should be consistent between pip and build.

@henryiii henryiii merged commit 3ea0a6c into pypa:main May 10, 2024
@mayeut mayeut deleted the pip-respect-constraints branch May 11, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants