Skip to content

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Feb 20, 2024

After 3 years, I finally contributed to delocate with PR is adding validation of platform tag against real requirements.

As many users open issues in this repository even when should in some other package, I think is worth to at least opening PR for better visibility.

This PR should not be merged before the next delocate release.

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this @Czaki ! A big improvement for sure.

Co-authored-by: Joe Rickerby <[email protected]>
@henryiii henryiii marked this pull request as draft February 26, 2024 17:26
@henryiii
Copy link
Contributor

I set this to draft to make it less tempting to merge before delocate is ready. :)

@henryiii
Copy link
Contributor

CC #1796.

@henryiii
Copy link
Contributor

Can it also detect of the arch is wrong? Missing Apple Silicon parts on a universal or arm wheel?

@Czaki Czaki marked this pull request as ready for review March 25, 2024 08:39
@Czaki
Copy link
Contributor Author

Czaki commented Mar 25, 2024

Can it also detect of the arch is wrong? Missing Apple Silicon parts on a universal or arm wheel?

Not in the current state. When creating PR, I assume that some of the inner binary could be single arch only. But will raise an error if there is no binary with a given arch here: https://github.com/matthew-brett/delocate/blob/526cc494e4c5750380a6d6ad3d31a2040ff63c60/delocate/delocating.py#L798

It is possible to extend the check to validate archs, but will require to use a dependency graph in place of simple scan files.

As delocate has been released 2 days ago, I mark it as ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants