Skip to content

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Feb 11, 2024

Only pass arguments that were set by the action to cibuildwheel.

Also add tests for action only & config-file arguments.

This allows to remove the workaround for pwsh update in #1741.

IMHO, this also brings some clarity when looking at the command-line that's being run:
e.g. https://github.com/pypa/cibuildwheel/actions/runs/7853848516/job/21433975640#step:8:64

Run if ($PSNativeCommandArgumentPassing) {

will now produce:

Run & "C:\hostedtoolcache\windows\Python\3.12.1\x64\python.exe" -m pipx run --spec "D:\a\cibuildwheel\cibuildwheel\./" cibuildwheel "sample_proj" --output-dir "wheelhouse"

Only pass arguments that were set to cibuildwheel.
@henryiii henryiii merged commit 53e2c74 into pypa:main Feb 17, 2024
@mayeut mayeut deleted the action-cibw-args branch February 17, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants