Skip to content

Don't attempt to test CPython 3.8 wheels on Apple Silicon. #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2022
Merged

Don't attempt to test CPython 3.8 wheels on Apple Silicon. #1171

merged 1 commit into from
Jul 14, 2022

Conversation

@joerick
Copy link
Contributor

@joerick joerick commented Jul 11, 2022

I've added a warning for users, so they know that it doesn't get tested.
See discussion in #1169 for the reason why.

Fixes #1168, fixes #1169

@joerick
Don't attempt to test CPython 3.8 wheels on Apple Silicon.
3524a5a 
I've added a warning for users, so they know that it doesn't get tested.
See discussion in #1169 for the reason why.

Fixes #1168, fixes #1169
@joerick
Copy link
Contributor Author

joerick commented Jul 11, 2022

I've verified the test passes on my local M1-

$ CIBW_PLATFORM=macos pytest test/test_macos_archs.py -k test_cp38_arm64_testing
============================= test session starts ==============================
platform darwin -- Python 3.11.0b3, pytest-7.1.2, pluggy-1.0.0
rootdir: /Users/joerick/Projects/cibuildwheel, configfile: pyproject.toml
plugins: xdist-2.5.0, forked-1.4.0, timeout-2.1.0
collected 6 items / 5 deselected / 1 selected                                  

test/test_macos_archs.py .                                               [100%]

======================= 1 passed, 5 deselected in 31.37s =======================

@mayeut mayeut merged commit 5780092 into main Jul 14, 2022
@mayeut mayeut deleted the macos3.8-arm64-testing branch July 14, 2022 09:42
@Czaki Czaki mentioned this pull request Jul 14, 2022
Closed
@daniel-larraz daniel-larraz mentioned this pull request Apr 30, 2025
Merged
github-merge-queue bot pushed a commit to cvc5/cvc5 that referenced this pull request May 13, 2025
@daniel-larraz
ci: Update cibuildwheel to v2.23.3 (#11855)
d2a6d8a 
This PR also includes changes to silence a few warnings. Specifically,
it explicitly enables PyPy builds, as they will be disabled by default
starting with cibuildwheel version 3. Additionally, it skips tests for
CPython 3.8 arm64 wheels, since these cannot be executed even on Apple
Silicon machines (see pypa/cibuildwheel#1171).
yoni206 pushed a commit to yoni206/cvc5 that referenced this pull request May 28, 2025
@daniel-larraz @yoni206
ci: Update cibuildwheel to v2.23.3 (cvc5#11855)
fbcd1e7 
This PR also includes changes to silence a few warnings. Specifically,
it explicitly enables PyPy builds, as they will be disabled by default
starting with cibuildwheel version 3. Additionally, it skips tests for
CPython 3.8 arm64 wheels, since these cannot be executed even on Apple
Silicon machines (see pypa/cibuildwheel#1171).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mayeut mayeut mayeut approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joerick @mayeut