Skip to content

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented May 19, 2024

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Update astroid to 3.2.2 to fix multiple false positives with generic class syntax added in Python 3.12 (PEP 695).
This included

  • useless-parent-delegation
  • attribute-defined-outside-init
  • access-member-before-definition
  • non-parent-init-called
  • unsubscriptable-object

It does not address the undefined-variable issue.

--
https://github.com/pylint-dev/astroid/releases/tag/v3.2.2

Closes #9406

@cdce8p cdce8p added False Positive 🦟 A message is emitted but nothing is wrong with the code python 3.12 backport maintenance/4.0.x labels May 19, 2024
@codecov
Copy link

codecov bot commented May 19, 2024

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 95.86%. Comparing base (3bf22d8) to head (8f2614d).
⚠️ Report is 638 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9655   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files         174      174           
  Lines       18907    18907           
=======================================
  Hits        18125    18125           
  Misses        782      782           
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 8f2614d

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 032ab32 into pylint-dev:main May 20, 2024
github-actions bot pushed a commit that referenced this pull request May 20, 2024
* Update astroid to 3.2.2

* Add tests for generic class syntax

(cherry picked from commit 032ab32)
@cdce8p cdce8p deleted the update-astroid-3.2.2 branch May 20, 2024 05:28
Pierre-Sassoulas pushed a commit that referenced this pull request May 20, 2024
* Update astroid to 3.2.2

* Add tests for generic class syntax

(cherry picked from commit 032ab32)

Co-authored-by: Marc Mueller <[email protected]>
@cdce8p cdce8p added this to the 3.2.2 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backported False Positive 🦟 A message is emitted but nothing is wrong with the code python 3.12

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[unsubscriptable-object] FP for generic classes (PEP 695)

2 participants