Drop isort 4, and clean up the resulting code
#10641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
the
Maintenance
Pierre-Sassoulas
changed the title
isortisort 4, and clean up the resulting code
Collaborator
Author
|
Forgot to remove one ignore, @Pierre-Sassoulas please review again 😅 |
Pierre-Sassoulas
approved these changes
Oct 12, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10641 +/- ##
==========================================
+ Coverage 95.94% 95.96% +0.02%
==========================================
Files 176 176
Lines 19519 19502 -17
==========================================
- Hits 18727 18715 -12
+ Misses 792 787 -5
🚀 New features to boost your workflow:
|
Contributor
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 3c444d6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Due to #10637 I took an interest in our current dependency on
isort.Yesterday I made a new release for
isortwhichpylintshould just support so I bumped the version constraints.At the same time we should remove the more than 6 years old version, because it also doesn't know about the stdlib imports of newer Python versions that we do support.
This means we can simplify our code a bit, which should help if we ever decide to fully remove
isortor replace it.