[Backport maintenance/3.3.x] Use custom Github App to authenticate backport job #10396
Conversation
![pylint-backport-bot[bot]](https://avatars.githubusercontent.com/u/121692054?s=60&v=4){kind=small}
(cherry picked from commit 6be8676)
|
What do you guys think @Pierre-Sassoulas @DanielNoord ? The only small thing left would be to change the commit author in the
https://github.com/tibdex/backport/blob/main/src/backport.ts#L260-L266 |
cdce8p
added
the
Maintenance
|
LGTM! |
|
LGTM, that would be for style point, we already have 150+ commits from github actions bot and the co-author is properly set anyway. (Beside we do not control the tidbex/backport so it could take some time) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maintenance/3.3.x #10396 +/- ##
==================================================
Coverage 95.84% 95.84%
==================================================
Files 174 174
Lines 18999 18999
==================================================
Hits 18210 18210
Misses 789 789 🚀 New features to boost your workflow:
|
The author for the squash-merge commit will be fine as well. It's just 526eb86 that's not entirely correct.
True. No commits in over two years. We would probably have to fork it into the |
There's also some advantages of not having to review new versions or worry about supply chain attacks. If you want to do it and it seems you want to do it, let's do it 😉 |
I'll probably finish #10382 first but after that 😄 |
…10487) * [ci] Install pylint before every test (#10388) (#10389) Co-authored-by: Marc Mueller <[email protected]> * Improve backport job permissions (#10390) (#10391) (cherry picked from commit 222ab20) * Resolve `possibly-used-before-assignment` false positives from `match` block assignments (#10393) (cherry picked from commit ad14b5b) * Use custom Github App to authenticate backport job (#10394) (#10396) (cherry picked from commit 6be8676) Co-authored-by: Marc Mueller <[email protected]> * Fix Pyreverse: Aggregations aren't filtered according to filter mode (PUB_ONLY, etc.) (#10379) (#10401) * updated diagrams.py file * added tests * updated tests * added test cases * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- (cherry picked from commit ed59632) Co-authored-by: pavan-msys <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Fix Mermaid printer rendering double underscores as bold formatting (#10403) (#10410) (cherry picked from commit 25a0f9e) Co-authored-by: Julian Grimm <[email protected]> Co-authored-by: Pierre Sassoulas <[email protected]> * Respect docstring-min-length in docparams extension (#10104) (#10434) (cherry picked from commit 7f5e996) Co-authored-by: Berker ŞAL <[email protected]> * Fix `unused-variable` false positive when using same name for multiple exceptions (#10436) (#10481) (cherry picked from commit 9e72867) Co-authored-by: Zen Lee <[email protected]> * Fix false-negative for used-before-assignment with postponed evaluation in function defs (#10482) (#10483) (cherry picked from commit d363fca) Co-authored-by: Marc Mueller <[email protected]> * Update pytest-benchmark requirement from ~=4.0 to ~=5.1 (#10066) (#10484) (cherry picked from commit f04761b) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump pylint to 3.3.8, update changelog (#10486) --------- Co-authored-by: Marc Mueller <[email protected]> Co-authored-by: Jacob Walls <[email protected]> Co-authored-by: pylint-backport-bot[bot] <212256041+pylint-backport-bot[bot]@users.noreply.github.com> Co-authored-by: pavan-msys <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Julian Grimm <[email protected]> Co-authored-by: Berker ŞAL <[email protected]> Co-authored-by: Zen Lee <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Backport 6be8676 from #10394.