Handle StopIteration error in infer_int. #731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes pylint-dev/pylint#3274. Prior to Python 3.7, StopIteration errors bubbled up through generators, so this wasn't an issue for astroid because the StopIteration error was handled later. Now StopIteration errors are converted to RuntimeErrors [1], so the same error handling doesn't work. [1]: https://www.python.org/dev/peps/pep-0479/
Contributor
|
Thanks for the PR @david-yz-liu ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
This fixes pylint-dev/pylint#3274. Prior to Python 3.7,
StopIterationerrors bubbled up through generators, so this wasn't an issue for astroid because theStopIterationerror was handled later. NowStopIterationerrors are converted toRuntimeErrors (PEP 479), so the same error handling doesn't work.Note: based on the above issue, I was able to come up with a minimal code example where calling
.inferred()raises an error on Python 3.7+ (see the test I added), but I wasn't actually able to determine out why aStopIterationerror occurred at all. I'm not familiar enough with astroid's inference to tell whether raisingStopIterationis the intended behaviour or not, so there might be a better fix.Type of Changes