Skip to content

Conversation

@jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Jul 12, 2024

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #2467

@jacobtylerwalls
Copy link
Member Author

Fixes/avoids a regression in pylint, not technically an astroid regression. Inference improved in #2458, exposing the fact that these utils don't really handle ambiguous results very cleanly.

@codecov
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 92.81%. Comparing base (6db3a60) to head (1c4dfda).
Report is 126 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2468      +/-   ##
==========================================
+ Coverage   92.75%   92.81%   +0.06%     
==========================================
  Files          94       94              
  Lines       11007    11022      +15     
==========================================
+ Hits        10209    10230      +21     
+ Misses        798      792       -6     
Flag Coverage Ξ”
linux 92.69% <100.00%> (+0.06%) ⬆️
pypy 92.81% <100.00%> (+0.06%) ⬆️
windows 92.79% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
astroid/nodes/node_classes.py 95.02% <100.00%> (+0.34%) ⬆️

@jacobtylerwalls jacobtylerwalls marked this pull request as ready for review July 13, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported Assigned once the backport is done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pylint checks against incorrect type with properties that have a getter and setter

3 participants