Replace and deprecate modutils.is_standard_module()

[avylove]

Type of Changes

	Type
	🐛 Bug fix
	✨ New feature
✓	🔨 Refactoring
	📜 Docs

Description

Deprecates modutils.is_standard_module() and splits functionality into two new functions:

• modutils.is_stdlib_module()

  • Checks if a module is part of the standard library. Uses sys.stdlib_module_names, which is a frozenset in the Python source. It is generated based on the source code and the logic is maintained upstream. This was introduced in 3.10
  • I backported the logic to 3.7, 3.8, and 3.9 to generate a shim to support those versions.
  • This has several advantages over the previous functionality
    • Faster
    • Not dependent on the runtime environment
    • No need to import the modules
    • No need to traverse the filesystem
    • Works for modules that are platform specific even on other platforms (termios, msvcrt, etc)

• modutils.module_in_path()

  • Checks if a module is in a specific path or paths
  • Uses logic lifted from is_standard_module()
    • Imports to get file, checks if file is in path

Closes #2012

[codecov]

Codecov Report

Merging #2015 (b330d40) into main (56a65da) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2015      +/-   ##
==========================================
+ Coverage   92.76%   92.78%   +0.01%     
==========================================
  Files          94       95       +1     
  Lines       10967    10998      +31     
==========================================
+ Hits        10174    10204      +30     
- Misses        793      794       +1     

Flag	Coverage Δ
linux	92.54% <100.00%> (+0.01%)	⬆️
pypy	88.49% <93.93%> (-0.02%)	⬇️
windows	92.33% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
astroid/_backport_stdlib_names.py	100.00% <100.00%> (ø)
astroid/manager.py	88.15% <100.00%> (ø)
astroid/modutils.py	87.32% <100.00%> (+0.53%)	⬆️

[DanielNoord]

I like the code and changes. Just some minor comments! This can definitely go in the next release!

[avylove]

I think I addressed all the comments. Please take another look when you get the chance.