Fix a false positive with user-defined `Enum` class #1967

mbyrnepr2 · 2023-01-14T14:05:22Z

Type of Changes

	Type
✓	🐛 Bug fix
	✨ New feature
	🔨 Refactoring
	📜 Docs

Description

Closes pylint-dev/pylint#5719

… `enum.Enum`. Calls to `Enum` are now inferred & the qualified name is checked. Refs pylint-dev/pylint#5719

for more information, see https://pre-commit.ci

astroid/brain/brain_namedtuple_enum.py

ChangeLog

for more information, see https://pre-commit.ci

ChangeLog

DanielNoord

I like the test, very elegant!

Couple of nits, rest LGTM!

astroid/brain/brain_namedtuple_enum.py

tests/unittest_brain.py

Co-authored-by: Daniël van Noord <[email protected]>

mbyrnepr2 · 2023-01-14T18:04:41Z

Thanks for those suggestions @DanielNoord; nothing I can disagree with there!

DanielNoord

I'd like to see coverage, but other than that this LGTM!

codecov · 2023-01-15T11:13:23Z

Codecov Report

Merging #1967 (a48aa4d) into main (49691cc) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

❗ Current head a48aa4d differs from pull request most recent head bc82724. Consider uploading reports for the commit bc82724 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1967      +/-   ##
==========================================
- Coverage   92.63%   92.63%   -0.01%     
==========================================
  Files          94       94              
  Lines       10869    10885      +16     
==========================================
+ Hits        10069    10083      +14     
- Misses        800      802       +2

Flag	Coverage Δ
linux	`92.39% <88.88%> (-0.01%)`	⬇️
pypy	`88.54% <88.88%> (-0.01%)`	⬇️
windows	`92.31% <88.88%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
astroid/brain/brain_namedtuple_enum.py	`92.95% <83.33%> (-0.45%)`	⬇️
astroid/raw_building.py	`92.30% <100.00%> (+0.13%)`	⬆️

DanielNoord · 2023-01-15T14:01:40Z

@mbyrnepr2 Do you think you can get the diff coverage to 100% here?

…ssue_5719

DanielNoord

Thanks for the additional test!

github-actions · 2023-01-15T17:27:02Z

The backport to maintenance/2.13.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.13.x maintenance/2.13.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.13.x
# Create a new branch
git switch --create backport-1967-to-maintenance/2.13.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c267397eda848544bcbea04e889815ac4faa6ba8
# Push it to GitHub
git push --set-upstream origin backport-1967-to-maintenance/2.13.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.13.x

Then, create a pull request where the base branch is maintenance/2.13.x and the compare/head branch is backport-1967-to-maintenance/2.13.x.

DanielNoord · 2023-01-17T21:37:31Z

@mbyrnepr2 Could you try and backport this? For some reason git doesn't recognize the maintenance branch for me locally.

Co-authored-by: Daniël van Noord <[email protected]> (cherry picked from commit c267397)

mbyrnepr2 · 2023-01-18T20:48:25Z

Done @DanielNoord: #1971. Let me know if any issues.

DanielNoord · 2023-01-18T20:49:51Z

Thanks! I feel bad for asking, but could you do #1970 as well? 😄

It's my own PR but I haven't been able to fix the broken git remote issue on my local machine.. 😅

Co-authored-by: Daniël van Noord <[email protected]> (cherry picked from commit c267397)

mbyrnepr2 and others added 3 commits January 14, 2023 15:04

Fix a false positive when an attribute named Enum was confused with…

dafc216

… `enum.Enum`. Calls to `Enum` are now inferred & the qualified name is checked. Refs pylint-dev/pylint#5719

[pre-commit.ci] auto fixes from pre-commit.com hooks

fce90e7

for more information, see https://pre-commit.ci

Remove Final import.

0a3bc5a

DanielNoord requested changes Jan 14, 2023

View reviewed changes

astroid/brain/brain_namedtuple_enum.py Outdated Show resolved Hide resolved

astroid/brain/brain_namedtuple_enum.py Outdated Show resolved Hide resolved

ChangeLog Outdated Show resolved Hide resolved

pre-commit-ci bot and others added 5 commits January 14, 2023 14:08

[pre-commit.ci] auto fixes from pre-commit.com hooks

0492046

for more information, see https://pre-commit.ci

Move Changelog entry

6427923

Use typing.Final with sys check

94002fd

[pre-commit.ci] auto fixes from pre-commit.com hooks

67c985a

for more information, see https://pre-commit.ci

Import sys

1230386

mbyrnepr2 commented Jan 14, 2023

View reviewed changes

ChangeLog Outdated Show resolved Hide resolved

Update ChangeLog

afbb47a

Pierre-Sassoulas added this to the 2.13.3 milestone Jan 14, 2023

Pierre-Sassoulas added the Bug 🪳 label Jan 14, 2023

DanielNoord requested changes Jan 14, 2023

View reviewed changes

astroid/brain/brain_namedtuple_enum.py Outdated Show resolved Hide resolved

astroid/brain/brain_namedtuple_enum.py Outdated Show resolved Hide resolved

tests/unittest_brain.py Outdated Show resolved Hide resolved

mbyrnepr2 and others added 3 commits January 14, 2023 19:03

Update tests/unittest_brain.py

fe4d84e

Co-authored-by: Daniël van Noord <[email protected]>

Update astroid/brain/brain_namedtuple_enum.py

2e164e2

Co-authored-by: Daniël van Noord <[email protected]>

Update astroid/brain/brain_namedtuple_enum.py

24263e1

Co-authored-by: Daniël van Noord <[email protected]>

Pierre-Sassoulas approved these changes Jan 14, 2023

View reviewed changes

Fix CI for Qt install

a48aa4d

DanielNoord approved these changes Jan 15, 2023

View reviewed changes

DanielNoord added the backport maintenance/2.13.x label Jan 15, 2023

mbyrnepr2 added 2 commits January 15, 2023 18:16

Merge branch 'main' of https://github.com/PyCQA/astroid into pylint_i…

02ae69b

…ssue_5719

Include a test for the case when an inferenceError is raised

bc82724

DanielNoord approved these changes Jan 15, 2023

View reviewed changes

DanielNoord enabled auto-merge (squash) January 15, 2023 17:19

DanielNoord disabled auto-merge January 15, 2023 17:26

DanielNoord merged commit c267397 into pylint-dev:main Jan 15, 2023

mbyrnepr2 deleted the pylint_issue_5719 branch January 15, 2023 17:32

Pierre-Sassoulas added the Needs backport Needs to be cherry-picked on the current patch version by an astroid's maintainer label Jan 17, 2023

mbyrnepr2 added a commit that referenced this pull request Jan 18, 2023

Fix a false positive with user-defined Enum class (#1967)

a06bf5c

Co-authored-by: Daniël van Noord <[email protected]> (cherry picked from commit c267397)

DanielNoord added a commit that referenced this pull request Jan 18, 2023

Fix a false positive with user-defined Enum class (#1967)

1c70358

Co-authored-by: Daniël van Noord <[email protected]> (cherry picked from commit c267397)

Pierre-Sassoulas removed the Needs backport Needs to be cherry-picked on the current patch version by an astroid's maintainer label Jan 18, 2023

DanielNoord mentioned this pull request Jan 18, 2023

Fix a false positive with user-defined Enum class (#1967) #1971

Merged

cdce8p added the backported Assigned once the backport is done label Jan 31, 2023

cdce8p modified the milestone: 2.13.3 Jan 31, 2023

Uh oh!

Fix a false positive with user-defined Enum class #1967

Fix a false positive with user-defined Enum class #1967

Uh oh!

Conversation

mbyrnepr2 commented Jan 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Changes

Description

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DanielNoord left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mbyrnepr2 commented Jan 14, 2023

Uh oh!

DanielNoord left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DanielNoord commented Jan 15, 2023

Uh oh!

DanielNoord left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 15, 2023

Uh oh!

DanielNoord commented Jan 17, 2023

Uh oh!

mbyrnepr2 commented Jan 18, 2023

Uh oh!

DanielNoord commented Jan 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix a false positive with user-defined `Enum` class #1967

Fix a false positive with user-defined `Enum` class #1967

mbyrnepr2 commented Jan 14, 2023 •

edited

Loading

codecov bot commented Jan 15, 2023 •

edited

Loading