Skip to content

Prevent a crash when inferring calls to str.format with invalid args #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2022
Merged

Prevent a crash when inferring calls to str.format with invalid args #1866

merged 1 commit into from
Nov 12, 2022

Conversation

@jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Nov 12, 2022

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

str.format can also emit ValueError or TypeError, so we need to catch them here.

Type of Changes

Type
✓ 🐛 Bug fix

Related Issue

Closes #1856

@jacobtylerwalls jacobtylerwalls added this to the 2.12.13 milestone Nov 12, 2022
@coveralls
Copy link

coveralls commented Nov 12, 2022

Pull Request Test Coverage Report for Build 3452215892

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.275%
Totals Coverage Status
Change from base Build 3417378415: 0.0%
Covered Lines: 9867
Relevant Lines: 10693
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@jacobtylerwalls jacobtylerwalls removed the request for review from DanielNoord November 12, 2022 21:02
@jacobtylerwalls jacobtylerwalls merged commit 04fad05 into pylint-dev:main Nov 12, 2022
@jacobtylerwalls jacobtylerwalls deleted the str-format-invalid-args branch November 12, 2022 21:02
Pierre-Sassoulas pushed a commit that referenced this pull request Nov 19, 2022
@jacobtylerwalls @Pierre-Sassoulas
Prevent a crash when inferring calls to str.format with invalid args (
2cb6417 
#1866)
Pierre-Sassoulas pushed a commit that referenced this pull request Nov 19, 2022
@jacobtylerwalls @Pierre-Sassoulas
Prevent a crash when inferring calls to str.format with invalid args (
5ce40b1 
#1866)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees

No one assigned

Labels

Crash 💥

Projects

None yet

Milestone

2.12.13

Development

Successfully merging this pull request may close these issues.

"TypeError: unsupported format string passed to NoneType.__format__" while running type inference in version 2.12.x

3 participants

@jacobtylerwalls @coveralls @Pierre-Sassoulas