Skip to content

Remove NoReturn #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2021
Merged

Remove NoReturn #1304

merged 1 commit into from
Dec 20, 2021

Conversation

tushar-deepsource
Copy link
Contributor

Description

Removes the unnecessary NoReturn type from a union.

Type of Changes

Type
✓ 🔨 Refactoring

@tushar-deepsource
Copy link
Contributor Author

In response to #1263 (comment)

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.9.1 milestone Dec 20, 2021
@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Dec 20, 2021
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on becoming an astroid contributor, you won't have to wait for us to approve your pipeline anymore ;)

@tushar-deepsource
Copy link
Contributor Author

:D

@Pierre-Sassoulas Pierre-Sassoulas merged commit df854be into pylint-dev:main Dec 20, 2021
@tushar-deepsource tushar-deepsource deleted the remove-noreturn branch December 20, 2021 10:31
@cdce8p
Copy link
Member

cdce8p commented Dec 21, 2021 •
edited
Loading

Just because mypy doesn't complain about it doesn't make it wrong. Actually this a a false-negative in mypy and pyright / pylance correctly detects it (in strict mode). I'll revert it.

cdce8p added a commit to cdce8p/astroid that referenced this pull request Dec 21, 2021
@cdce8p
Revert "Remove useless NoReturn in NodeNG.statement's typing (pylint-…
ce112bb 
…dev#1304)"

This reverts commit df854be.
@cdce8p cdce8p mentioned this pull request Dec 21, 2021
Merged
tushar-deepsource added a commit to tushar-deepsource/astroid that referenced this pull request Dec 24, 2021
@tushar-deepsource
Remove useless NoReturn in NodeNG.statement's typing (pylint-dev#1304)
823fbfc
Pierre-Sassoulas pushed a commit that referenced this pull request Dec 27, 2021
@cdce8p
Revert "Remove useless NoReturn in NodeNG.statement's typing (#1304)" (…
7b049a1 
…#1307)

This reverts commit df854be.
tushar-deepsource added a commit to tushar-deepsource/astroid that referenced this pull request Dec 29, 2021
@tushar-deepsource
Revert "Revert "Remove useless NoReturn in NodeNG.statement's typing (p…
96166d0 
…ylint-dev#1304)" (pylint-dev#1307)"

This reverts commit 7b049a1.
Pierre-Sassoulas pushed a commit that referenced this pull request Dec 29, 2021
@tushar-deepsource
Revert "Revert "Remove useless NoReturn in NodeNG.statement's typing (#…
7afd696 
…1304)" (#1307)" (#1319)

This reverts commit 7b049a1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@tushar-deepsource @cdce8p @Pierre-Sassoulas @DanielNoord