-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fix tests for GPUs lacking memory info from nvidia-smi
#10391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
please test that this work on A100, H100, and B100 and attach the logs. also please make ci green |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10391 +/- ##
==========================================
- Coverage 86.11% 85.83% -0.28%
==========================================
Files 496 501 +5
Lines 33655 34454 +799
==========================================
+ Hits 28981 29574 +593
- Misses 4674 4880 +206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Providing log files per @puririshi98’s request: |
Additionally, I fixed the following CI issues as requested by @puririshi98:
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thnx
The
nvidia-smi
does not report memory usage on certain newer GPU cards, likely due to changes in driver or hardware support:As a result, two PyG tests are now failing:
This PR addresses and fixes the issue.