Skip to content

Use assert_duckarray_allclose instead of rounding the array #9313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Illviljan merged 5 commits into from
Aug 6, 2024
Merged

Use assert_duckarray_allclose instead of rounding the array #9313

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e8e9cce
Cleanup test_coding_times
Illviljan Jul 9, 2024
1d6077e
Update test_coding_times.py
Illviljan Jul 9, 2024
4db0c4e
Merge branch 'main' into test_coding_times_cleanup
Illviljan Aug 4, 2024
c5a7d8a
Update test_coding_times.py
Illviljan Aug 4, 2024
82c6909
Update test_coding_times.py
Illviljan Aug 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xarray/tests/test_coding_times.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,14 +146,14 @@ def test_cf_datetime(num_dates, units, calendar) -> None:
# https://github.com/Unidata/netcdf4-python/issues/355
assert (abs_diff <= np.timedelta64(1, "s")).all()
encoded1, _, _ = encode_cf_datetime(actual, units, calendar)
assert_array_equal(num_dates, np.around(encoded1, 1))
assert_duckarray_allclose(num_dates, encoded1)

if hasattr(num_dates, "ndim") and num_dates.ndim == 1 and "1000" not in units:
# verify that wrapping with a pandas.Index works
# note that it *does not* currently work to put
# non-datetime64 compatible dates into a pandas.Index
encoded2, _, _ = encode_cf_datetime(pd.Index(actual), units, calendar)
assert_array_equal(num_dates, np.around(encoded2, 1))
assert_duckarray_allclose(num_dates, encoded2)


@requires_cftime
Expand Down